[Geomagic] Fix crash when drawDevice is set to true and add option to log haptic thread speed #5850
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: fix
hugtalbot
reviewed
Jan 7, 2026
Co-authored-by: Hugo <[email protected]>
hugtalbot
approved these changes
Jan 13, 2026
Comment on lines
+75
to
+76
| static auto last_time = std::chrono::high_resolution_clock::now(); | ||
| static int counter = 0; |
Contributor
Author
There was a problem hiding this comment.
to init only once, this method is directly repeated inside the haptic thread
bakpaul
approved these changes
Jan 13, 2026
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if